Added dialogflow_agent_to_link field to the google_discovery_engine_chat_engine resource #11889
Conversation
…gine_chat_engine resource
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 13 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
| required: true | ||
| Exactly one of `agent_creation_config` or `dialogflow_agent_to_link` must be set. | ||
| immutable: true | ||
| ignore_read: true |
There was a problem hiding this comment.
why are we adding ignore_read to this one here? Did it not correctly read before?
There was a problem hiding this comment.
ignore_read is set on the parent field here
So I decided to repeat it for both nested fields to have it set more explicit in the code, but you are right, it can be removed since parent field has it set already
Added
chat_engine_config.dialogflow_agent_to_linkfield to thegoogle_discovery_engine_chat_engineresource.Field exists in the API and allows users to make use of an existing DialogFlow Agent (for ex. deployed by terraform), hence agent management can be done by terraform, including security settings, page configurations and many more.
Also fixes hashicorp/terraform-provider-google#19678
Release Note Template for Downstream PRs (will be copied)